imapclient: add Dial() for unencrypted connections

emersion / go-imap

📥 An IMAP library for clients and servers

MIT License

2.07k stars 292 forks source link

imapclient: add Dial() for unencrypted connections #593

Closed bitfehler closed 6 months ago

bitfehler commented 7 months ago

I mean, I certainly don't insist that this method should exist, but something gave me the impression you might think so :wink:

emersion commented 7 months ago

Ah, right! I was holding off on this one because I prefer unencrypted connections to be explicit, but maybe I'm worrying too much and should just go with the flow of the rest of the Go ecosystem…

bitfehler commented 7 months ago

As I said, it's up to you. I can make the comment more explicit, or change the name to DialInsecure() or whatnot, or we can close this and I modify your tokidoki-patch to use New() directly.

emersion commented 6 months ago

Alright, sounds reasonable to me to rename to DialInsecure!

bitfehler commented 6 months ago

Exquisite choice! :clinking_glasses: :wink: