search

emersion / go-imap

📥 An IMAP library for clients and servers
MIT License
2.02k stars 288 forks source link

Support ID command #621

Closed quzhi1 closed 3 weeks ago

quzhi1 commented 3 weeks ago

Hi @emersion ,

I based my PR on https://github.com/emersion/go-imap/pull/601, and addressed all your comments in this one. Really appreciate your review 🙏

I have one question though... The response of c.Id(...).Wait() is somehow always empty. I am not sure why the library can't read the response from server. Can you help me figure out why?

Great thanks!

quzhi1 commented 3 weeks ago

@emersion Can you take a look again? 🙏 The PR is updated

quzhi1 commented 3 weeks ago

@emersion Thanks for another round of review. The PR is updated. Can you take a look again?

quzhi1 commented 3 weeks ago

@emersion Can you merge it? I don't have permission to merge this pull request...

emersion commented 3 weeks ago

Sorry, I wanted to cleanup the commit history and reword/reformat the docs a bit, but I got interrupted. Merging now!

quzhi1 commented 3 weeks ago

Thank you! This really means a lot! Really appreciate the help 👍 👍 👍