Closed mschneider82 closed 3 years ago
@emersion @foxcpp can you help to "fix" this? It is not related to #101, because no error is returned.
ah increasing maxLineOctets helped to fix it! i will keep this open to discuss about exporting the value or increasing the default value
I've also run into this, with a lot of mail from mailing lists with "X-MO-Address"-headers that are > 7000 chars long. The longest headers in my inbox seem to be clocking in at 7983 chars, so i would vote for increasing the default to at least 8000 chars.
Any update on this? @emersion Should be a quick fix, if you agree to the change, i'd like to send a PR. :)
Increasing octet limit to 8000 would allow headers up to 7.62 MiB in total. Would it be practical to lower maxHeaderLines to at least 700 or even 500 at the same time?
The longest headers in my inbox seem to be clocking in at 7983 chars, so i would vote for increasing the default to at least 8000 chars.
But then someone will run into a message with line whose length is 8001 and will send a PR to increase the limit. It doesn't seem like there is a one-size-fits-all limit here.
https://github.com/emersion/go-message/pull/82 should help with this issue by at least allowing the user to override the limits. Also mentioned there is that I'd prefer a global header size limit instead of a line length + header count limit.
Maybe just read content before maxLineOctets and skip exceeded content, no error or panic.
Silently dropping content is not a good solution.
Then the only way is #82. :)
It would be nice if the headers below the long line also get's parsed, skipping the "long header value" would be fine to me. I never need such long headers values but many others (like Subject).
May Reader Options can handle every use case.
The previous attempt for setting up reader options didn't work out. However, a new PR is proposed in #123. The new PR does something similar by making header limits per entire header, not per individual header line. This should allow a fix to this issue here.
Hi,
i receive mails with some strange long header X-CMAE-Envelope, unfortuatelly all headers below that long header cannot be parsed.