search

emersion / go-msgauth

🔏 A Go library and tools for DKIM, DMARC and Authentication-Results
MIT License
162 stars 51 forks source link

Fix dkim verification issues and dmarc alignment default #19

Closed huicao closed 4 years ago

huicao commented 4 years ago

Change-Id: I0e023a602004bb18f573321c5811d1c876312663 Default DMARC policy is relax https://blog.returnpath.com/demystifying-the-dmarc-record/ Reduce all sequences of WSP within a line to a single SP character. https://tools.wordtothewise.com/rfc/6376#section-3.4

codecov-io commented 4 years ago

Codecov Report

Merging #19 into master will decrease coverage by 0.28%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   66.46%   66.18%   -0.29%     
==========================================
  Files           7        7              
  Lines         838      831       -7     
==========================================
- Hits          557      550       -7     
  Misses        212      212              
  Partials       69       69
Impacted Files Coverage Δ
dkim/canonical.go 80.95% <100%> (-1.66%) :arrow_down:
dkim/query.go 30% <100%> (+1.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 55b7567...5eaacad. Read the comment docs.

emersion commented 4 years ago

Reduce all sequences of WSP within a line to a single SP character.

Can we add this to the list of tests?

huicao commented 4 years ago

I just added one test for this

huicao commented 4 years ago

What's else can I do to have this merged?

emersion commented 4 years ago

Thanks!