search

emersion / go-msgauth

🔏 A Go library and tools for DKIM, DMARC and Authentication-Results
MIT License
162 stars 51 forks source link

dkim: remove Signer.SignatureValue #21

Closed emersion closed 4 years ago

emersion commented 4 years ago

The header key is case-sensitive and the folding cannot be changed. Remove this function as it's too easy to get it wrong 1.

This is a breaking change.

cc @foxcpp

codecov-io commented 4 years ago

Codecov Report

Merging #21 into master will increase coverage by 0.32%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #21      +/-   ##
=========================================
+ Coverage   66.18%   66.5%   +0.32%     
=========================================
  Files           7       7              
  Lines         831     827       -4     
=========================================
  Hits          550     550              
+ Misses        212     208       -4     
  Partials       69      69
Impacted Files Coverage Δ
dkim/sign.go 68.58% <ø> (+1.71%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4a03be5...6a9b95b. Read the comment docs.