search

emersion / go-msgauth

🔏 A Go library and tools for DKIM, DMARC and Authentication-Results
MIT License
162 stars 51 forks source link

Allow setting lookup DNS/TXT function #25

Closed huicao closed 4 years ago

huicao commented 4 years ago

This change can allow us cache the record to minimize latency

codecov-io commented 4 years ago

Codecov Report

Merging #25 into master will decrease coverage by 0.16%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #25      +/-   ##
==========================================
- Coverage   66.50%   66.34%   -0.17%     
==========================================
  Files           7        7              
  Lines         827      829       +2     
==========================================
  Hits          550      550              
- Misses        208      210       +2     
  Partials       69       69
Impacted Files Coverage Δ
dkim/query.go 29.16% <0.00%> (-0.84%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 74fc936...89e8201. Read the comment docs.

foxcpp commented 4 years ago

Ref. https://github.com/emersion/go-msgauth/issues/4 https://github.com/emersion/go-msgauth/issues/10

huicao commented 4 years ago

I agree. Would you mind to bring up your patch again? I think this is very useful.