search

emersion / go-msgauth

🔏 A Go library and tools for DKIM, DMARC and Authentication-Results
MIT License
162 stars 51 forks source link

Correctly wrap dkim header. #30

Closed wjywbs closed 4 years ago

wjywbs commented 4 years ago

This change has been validated by sending large email campaigns.

codecov-commenter commented 4 years ago

Codecov Report

Merging #30 into master will decrease coverage by 1.40%. The diff coverage is 46.51%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   66.30%   64.90%   -1.41%     
==========================================
  Files           7        7              
  Lines         837      869      +32     
==========================================
+ Hits          555      564       +9     
- Misses        213      233      +20     
- Partials       69       72       +3
Impacted Files Coverage Δ
dkim/header.go 75.63% <43.90%> (-17.48%) :arrow_down:
dkim/sign.go 68.58% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e4c8736...c74373c. Read the comment docs.

emersion commented 4 years ago

Thanks for taking the time to write a patch, but this has been fixed in https://github.com/emersion/go-msgauth/pull/29

wjywbs commented 4 years ago

Thanks. By the way, this fixes the h= wrapping as well.