emersion / go-msgauth

🔏 A Go library and tools for DKIM, DMARC and Authentication-Results
MIT License
162 stars 51 forks source link

Export selector and DNS response via Verification #42

Open kmille opened 3 years ago

kmille commented 3 years ago

This makes debugging much easier. It can be difficult to debug issues as the verification struct does not contain all information used for the verification like the public key or the selector. If you change the DNS record and don't know if DNS is still cached further information can help.

Thank you for writing this library!

kmille

emersion commented 3 years ago

Can't we add more context to the error messages instead?

kmille commented 3 years ago

I want to write a mail tester like mail-tester.com. If something fails, I want to show the used public keys, selector, etc. as debug infos. I think for this use case a more verbose error message is not sufficient. Having access to all fields makes it easier.

kmille commented 3 years ago

Hey, can you give me a status update what prevents you from merging?