internal: r/w roundtrip of Time broken

emersion / go-webdav

A Go library for WebDAV, CalDAV and CardDAV

MIT License

326 stars 72 forks source link

Closed sbinet closed 3 years ago

sbinet commented 3 years ago

hi,

trying to retrieve the list of contacts (served by hydroxide) I noticed the internal.Time value XML encoding/decoding roundtrip was broken:

marshaling is done with time.RFC1123Z
unmarshaling with net/http.ParseTime that only has: [http.TimeFormat, time.RFC850, time.ANSIC] as a list of possible time formats.

emersion commented 3 years ago

Ooops. I guess we should probably just use http.TimeFormat. Need to be careful about:

The time being formatted must be in UTC for Format to generate the correct format.