search

emersion / hydroxide

A third-party, open-source ProtonMail CardDAV, IMAP and SMTP bridge
MIT License
1.63k stars 126 forks source link

Fix issue #149 #204

Closed julianfairfax closed 2 years ago

julianfairfax commented 2 years ago

I've fixed issue #149 by commenting out lines 311 to 313 of imap/mailbox.go. This obviously doesn't add the functionality, but prevents K-9 Mail from interpreting the output as an error, upon which the application fetches all mail with absolutely no issue.

emersion commented 2 years ago

Yeah, sorry, but this isn't mergeable. We should implement the query properly when we can, and error out if we can't reply.

julianfairfax commented 2 years ago

The problem is that showing an error actually creates more problems than it solves. (At least for this case)

emersion commented 2 years ago

Yes, for this very specific case, it does. For pretty much every other case, it'll return wrong results. I'd rather fix this properly than adding bad workarounds.