search

emersion / hydroxide

A third-party, open-source ProtonMail CardDAV, IMAP and SMTP bridge
MIT License
1.64k stars 126 forks source link

Remove deprecated IMAP extension dependencies #224

Closed CairnThePerson closed 2 years ago

CairnThePerson commented 2 years ago

Hey! I'm packaging Hydroxide for Guix, and I noticed that go-imap-move and go-imap-specialuse have both been merged into go-imap. In order to avoid packaging the outdated extensions as dependencies, I've attempted to remove them. I'm not a Go developer, so I'm wary that what I intend might not be as simple as what I'm submitting, but it builds and runs (so far) without issue.

If anyone would like to correct my ignorance, that'd be great. Otherwise, I hope this PR can be merged soon. :crossed_fingers:

CairnThePerson commented 2 years ago

Hah, great, the build failed. I must have made a mistake when building locally; sorry about that.

CairnThePerson commented 2 years ago

What a mess. I was having trouble with the Guix build system; it kept falling back to a different commit making me assume the package built. I finally figured out each reference to go-imap-move and go-imap-specialuse though. Just gonna have to squash these commits if this change is accepted. :sweat_smile:

emersion commented 2 years ago

Yup, looks good! Please squash and I'll merge.