Fix [9001] error upon login

emersion / hydroxide

A third-party, open-source ProtonMail CardDAV, IMAP and SMTP bridge

MIT License

1.63k stars 126 forks source link

Fix [9001] error upon login #225

Closed pufferffish closed 2 years ago

pufferffish commented 2 years ago

This pull request fixes #179. I skimmed through proton-python-client and it seems that User-Agent and x-pm-appversion is needed for login to work.

I tried this on two different protonmail accounts on two different IPs and login works for me.

emersion commented 2 years ago

We already set X-Pm-Appversion. The User-Agent change may fix it for some users, but will break it for others.

pufferffish commented 2 years ago

We already set X-Pm-Appversion. The User-Agent change may fix it for some users, but will break it for others.

I see. Would it be a good idea to try numerous User Agents instead of fixing it to one specific string then? Or provide an argument to allow custom user agent instead?

emersion commented 2 years ago

No, that would be a workaround. The proper fix would be #218.