emersion / hydroxide

A third-party, open-source ProtonMail CardDAV, IMAP and SMTP bridge
MIT License
1.64k stars 126 forks source link

Document the undocumented options #237

Closed bruceleerabbit closed 1 year ago

bruceleerabbit commented 1 year ago

It’s clear from other bug reports that an HTTPS_PROXY variable is recognized and treated (though I think mistreated ATM). In any case, that variable should be mentioned on the --help page.

The --help page also neglects to mention that a session ID cookie can be passed as an argument to the “auth” command.

emersion commented 1 year ago

It’s clear from other bug reports that an HTTPS_PROXY variable is recognized and treated (though I think mistreated ATM). In any case, that variable should be mentioned on the --help page.

That's the standard Go library's doing. hydroxide has no special code for this.

The --help page also neglects to mention that a session ID cookie can be passed as an argument to the “auth” command.

Nope, cookies aren't accepted.

bruceleerabbit commented 1 year ago

The --help page also neglects to mention that a session ID cookie can be passed as an argument to the “auth” command.

Nope, cookies aren't accepted.

If that’s true, contrary to what @dvalter says here:

https://github.com/emersion/hydroxide/issues/179#issuecomment-855283386

then that’s yet another bug. Why are illegal parameters not triggering a syntax error?

emersion commented 1 year ago

This comment is about a fork.

bruceleerabbit commented 1 year ago

This comment is about a fork.

But I’m not running a fork. I’m running the emersion/hydroxide version as follows:

HTTPS_PROXY='socks5://127.0.0.1:9050' hydroxide -api-endpoint https://protonmailrmez3lotccipshtkleegetolb73fuirgj7r4o4vfu7ozyd.onion/api auth "$UID" "$sessionID"

If the $sessionID is only supported in the fork, then the version I have should terminate with a syntax error saying something like “too many args”.

acheong08 commented 1 year ago

I made a fork for my own use.

Some changes: