emersion / libliftoff

Lightweight KMS plane library
MIT License
75 stars 7 forks source link

Skip setting properties that haven't changed #37

Open emersion opened 4 years ago

emersion commented 4 years ago

Atomic test-only commits set property values for the next commit when they succeed. We don't need to keep setting the same property values over and over again.

emersion commented 4 years ago

Atomic test-only commits set property values for the next commit when they succeed.

Nope, that's false. Was confused because wlroots re-used the atomic requests between commits.

Only regular commits set property values for subsequent commits.


Another thing to keep in mind is that a VT switch messing up our previous state may happen at any time. Also there's no guarantee the compositor has performed a regular atomic commit after liftoff_output_apply.