search

emersion / mako

A lightweight Wayland notification daemon
https://wayland.emersion.fr/mako
MIT License
2.24k stars 138 forks source link

Mako stops showing notification #416

Open sunox1 opened 2 years ago

sunox1 commented 2 years ago

I seem to be having the same issue that is described in this closed issue:

https://github.com/riverwm/river/issues/226

In short, mako displays notifications for a while, and then stops. makoctl reload revives it.

I am running mako on Gentoo using the latest build (version 1.6). I raised this issue on the Gentoo forums, and the people I spoke to there redirected me here as they did not feel it was a Gentoo issue.

I start mako with exec sway in sway's config. I use elogind - not systemd - and start sway with dbus-run-session sway. I'm not sure if this is even relevant, but dbus seems to work perfectly well on my system.

I also run mako on a Debian machine, using the same config, and starting mako in the same way. mako works flawlessly on this machine now, although I seem to recall it having the same issue described above at some point, and it eventually went away.

Does anyone know what might cause mako to stop showing notifications?

fluix-dev commented 2 years ago

No clue on whether this is the cause or not, but just want to mention that the TODO which ifreund pointed out in that thread is still there:

https://github.com/emersion/mako/blob/0e1a3637df6f85bdb931aa0aa27d645420803b77/wayland.c#L720-L722

nagisa commented 2 years ago

Duplicate of https://github.com/emersion/mako/issues/404 (also what a fitting issue number for that one…)

sunox1 commented 2 years ago

Thanks for the comments @fluix-dev and @nagisa.

I'm not sure how exactly to interpret the TODO, but it sounds like something I can't control. Still interesting to know.

And it seems I missed the earlier message - my mistake. Please let me know if I should close this one.

CameronNemo commented 2 years ago

Updating to mako git fixed this issue for me. @sunox1 Did you try that?

loserMcloser commented 2 years ago

I have the same issue with the community package of mako on Archlinux.

If mako-git fixes the issue, can there be a release/version-increment so that the community package in archlinux gets updated with the fix?

CameronNemo commented 2 years ago

I cannot tell if you actually tested mako built from git. If you did and it solves the issue feel free to pester the maintainer here to do a release, then Arch should pick it up promptly.

I just did not want to bother if my system is simply a fluke.

loserMcloser commented 2 years ago

I cannot tell if you actually tested mako built from git.

I hadn't when I commented, but I have now and it seems like it fixes the problem for me. It's not certain though because it's not consistently reproducible for me --- it seems to occur after my system has been sitting locked for a while, and then I no longer get notifications showing up after I unlock until I run makoctl reload. I thought the cause might be notifications being received while locked (from an open GMail tab, for example), but if I do something like sleep 5; notify-send test and then lock my screen during the sleep it doesn't seem to trigger the problem.

I've built and installed mako-git and haven't had the issue since. I'll report back if it crops up again.

If you did and it solves the issue feel free to pester the maintainer here to do a release, then Arch should pick it up promptly.

I hoped that commenting here on the issue with the specific suggestion of putting out a release would count as "pester[ing] the maintiner." ;)

aereaux commented 2 years ago

I think this is fixed by https://github.com/emersion/mako/commit/6caaa557d1bb767a037b36bb294bcb78059fb2ba or a related change. It seems to happen sometimes when my screen is off (so when I have 0 outputs).