emersion / mrsh

A minimal POSIX shell
MIT License
489 stars 35 forks source link

configure: Only add -I CFLAGS from readline #116

Closed mkhl closed 5 years ago

mkhl commented 5 years ago

Adding the readline CFLAGS to our own can define undesired symbols, like for _GNU_SOURCE and _XOPEN_SOURCE. We take extra precautions to remove _GNU_SOURCE but a stray _XOPEN_SOURCE can break our build due to redefined symbols.

This change modifies the pkgconfig invocation to only add the -I CFLAGS of the readline package, which don't include symbol definitions and spares us the trouble of having to remove them.

Fixes #115