search

emersion / mrsh

A minimal POSIX shell
MIT License
492 stars 35 forks source link

make history xdg base directory specification compliant #158

Open ghost opened 4 years ago

ghost commented 4 years ago

fixes #157

ghost commented 4 years ago

I'm not sure why that fails on freebsd...

JohnHolmesII commented 4 years ago

FreeBSD has some macro magic going on with dirname https://github.com/freebsd/freebsd/blob/release/12.1.0/include/libgen.h

If you want to use dirname, you will likely need to include a FreeBSD ifdef or something equivalent. The joy is overwhelming :smile:

ghost commented 4 years ago

how is this even failing, the log seems fine. with the freebsd magic I at least had errors...

emersion commented 4 years ago

Ah, don't worry about it. I'll patch the CI so that the annotator only runs for the master branch.

ghost commented 4 years ago

Well, at least it's not my fault this time then :D

emersion commented 3 years ago

Reported the FreeBSD bug here: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251270

ghost commented 3 years ago

Do you want to wait for FreeBSD to fix the linked bug or is there something else holding up this PR?

emersion commented 3 years ago

Sorry, I won't have time to look into this in the near future.