wlroots: output chooser "/usr/bin/slurp -f %o -o" failed

shibumi commented 3 years ago

On Arch Linux invoking the slurp command fails, although the slurp binary is there.

Logs:

❯ systemctl status --user xdg-desktop-portal-wlr.service
● xdg-desktop-portal-wlr.service - Portal service (wlroots implementation)
     Loaded: loaded (/usr/lib/systemd/user/xdg-desktop-portal-wlr.service; static)
     Active: active (running) since Mon 2021-06-07 12:23:55 CEST; 28s ago
   Main PID: 52656 (xdg-desktop-por)
      Tasks: 2 (limit: 37564)
     Memory: 1.2M
        CPU: 14ms
     CGroup: /user.slice/user-1000.slice/user@1000.service/app.slice/xdg-desktop-portal-wlr.service
             └─52656 /usr/lib/xdg-desktop-portal-wlr

Jun 07 12:23:55 motoko.shibumi.dev systemd[2121]: xdg-desktop-portal-wlr.service: Deactivated successfully.
Jun 07 12:23:55 motoko.shibumi.dev systemd[2121]: Stopped Portal service (wlroots implementation).
Jun 07 12:23:55 motoko.shibumi.dev systemd[2121]: Starting Portal service (wlroots implementation)...
Jun 07 12:23:55 motoko.shibumi.dev systemd[2121]: Started Portal service (wlroots implementation).
Jun 07 12:24:12 motoko.shibumi.dev xdg-desktop-portal-wlr[52760]: /bin/sh: line 1: /usr/bin/slurp -f %o -o: No such file or directory
Jun 07 12:24:12 motoko.shibumi.dev xdg-desktop-portal-wlr[52656]: 2021/06/07 12:24:12 [ERROR] - wlroots: output chooser "/usr/bin/slurp -f %o -o" failed
Jun 07 12:24:12 motoko.shibumi.dev xdg-desktop-portal-wlr[52656]: 2021/06/07 12:24:12 [ERROR] - wlroots: no output found
❯ which slurp
/usr/bin/slurp

Slurp Version: 1.3.2-1 xdg-desktop-portal-wlr Version: 0.4.0-1 wlroots verson: 0.13.0-1

columbarius commented 3 years ago

Are you using a config file? If so, could you please paste it?

shibumi commented 3 years ago

@columbarius

[screencast]
output_name=
max_fps=30
chooser_cmd="/usr/bin/slurp -f %o -o"
chooser_type=simple

Note: I've added the full path /usr/bin/slurp, because it fails with slurp -f %o -o as well..

columbarius commented 3 years ago

@shibumi Please remove the quotes from the chooser_cmd. We moved from iniparser to inih for parsing and the new parser doesn't remove them when parsing, so xdg-desktop-portal tries to launch "/usr/bin/slurp -f %o -o" with the quotes.

danshick commented 3 years ago

We should do release notes for changes like that.

emersion commented 3 years ago

This was mentioned in the release notes.

shibumi commented 3 years ago

@columbarius thanks! fixed.

danshick commented 3 years ago

This was mentioned in the release notes.

I was looking at 0.4.0 instead of 0.3.0 where it landed.

emersion / xdg-desktop-portal-wlr

wlroots: output chooser "/usr/bin/slurp -f %o -o" failed #143