emersion / xdg-desktop-portal-wlr

xdg-desktop-portal backend for wlroots
MIT License
596 stars 59 forks source link

Fix potential memory corruption when reading bools #155

Closed GermainZ closed 3 years ago

GermainZ commented 3 years ago

As per man sd_bus_message_read, boolean items should be read into an int rather than a bool as the latter can cause memory corruption.

(I'm not sure if this currently causes any issues in xdpw, but I did encounter this bug in a portal I'm writing that's based on xdpw.)