search

emersion / xdg-desktop-portal-wlr

xdg-desktop-portal backend for wlroots
MIT License
591 stars 56 forks source link

Restore screencast session part 1 #179

Closed columbarius closed 1 year ago

columbarius commented 2 years ago

First shot at implementing restoring screencast sessions.

The first part skips implementing the user facing interactive part and adds an environment variable to enable this experimental feature.

Implements #170

columbarius commented 2 years ago

Got the dbus stuff working!

columbarius commented 2 years ago

Maybe this could be useful with an option to allow at least the transient mode to get rid of the annoying second query from chromium before making this available via the chooser protocol?

Algram commented 2 years ago

@columbarius What would be needed to get this in a mergeable state? Are there any problems left or just cleanup?

columbarius commented 2 years ago

@Algram This is a PoC for the dbus side. If you want a lite version of it so chromium won't show the dialog twice, this could be easily completed. To support restoring sessions after a restart of the application all the user facing dialogs needs to be done. This also requires a more complex chooser.

Algram commented 2 years ago

@columbarius My problem is that I am using the OBS Pipewire capturing which currently re prompts me every time I start OBS right now.

I already tried your comment here: https://github.com/emersion/xdg-desktop-portal-wlr/issues/170#issuecomment-974891571 but this does not seem to remove the prompt.

columbarius commented 2 years ago

I already tried your comment here: #170 (comment) but this does not seem to remove the prompt.

Try restarting xdpw, or just restart your pc after changing the config. If you see still the prompt, please open a separate issue.