emersion / xdg-desktop-portal-wlr

xdg-desktop-portal backend for wlroots
MIT License
591 stars 57 forks source link

screencast: remove check on loop_iterate #183

Closed columbarius closed 2 years ago

columbarius commented 2 years ago

According to the documentation [1] pw_loop_iterate (a macro for spa_loop_control_iterate) will return the number of dispatched fd's which don't have any value for error handling.

[1] https://docs.pipewire.org/group__spa__loop.html#ga3bae0b32100f5752b3372a505c8e04f6

emersion commented 2 years ago

We should still check for errors with if (pw_loop_iterate(…) < 0) and ideally break out of the loop on error.