search

emersion / xdg-desktop-portal-wlr

xdg-desktop-portal backend for wlroots
MIT License
579 stars 53 forks source link

screencast: simplify wl_drm format code conversions #301

Closed emersion closed 2 months ago

emersion commented 2 months ago

All formats except ARGB8888 and XRGB8888 are guaranteed to always match the DRM FourCC.

columbarius commented 2 months ago

Should we also update the mapping between drm and PipeWire formats for all possible values?

emersion commented 2 months ago

I don't think there is a straightforward generic mapping for these, like there is for wl_shm and DRM FourCC?

columbarius commented 2 months ago

My idea was to manually update the conversion to formats available in PipeWire, but this can be done when needed.

emersion commented 2 months ago

Right, this patch is mostly intended as a cleanup to avoid unnecessary repetition and remove the need to maintain format lists for wl_shm.