Monitor hotplug - Githubissues

emersion / xdg-desktop-portal-wlr

xdg-desktop-portal backend for wlroots

MIT License

595 stars 59 forks source link

Monitor hotplug #76

Closed columbarius closed 2 years ago

columbarius commented 3 years ago

Support hotplug in for monitors

Problems:

[x] Close stream graceful on when unplugging a monitor 1 2 3. Solved by #176
[x] Added monitor is missing name (nil), or name contains garbage. Solved by #109
[x] Unplugging and replugging a monitor can damage other output entries. Solved by #109

danshick commented 3 years ago

@columbarius Will the implementation for #137 help with this as well? I know proper stream cleanup will be a necessary part of that PR, so maybe it makes sense to address this at the same time.

columbarius commented 3 years ago

Could be. We should be able to shutdown more gracefully. The interesting thing is, if we are fast enough to signal pipewire that we are stopping the stream (or just stopping the wlroots part) before we are trying to request a screencopy for a monitor, which doesn't exist anymore. I just don't know, what each component can handle. I think we have to take a look at it after the restructure.

columbarius commented 2 years ago

All points are done, so monitor hotplug should be working.