Allow macOS architectures to be configured

emeryberger / Hoard

The Hoard Memory Allocator: A Fast, Scalable, and Memory-efficient Malloc for Linux, Windows, and Mac.

http://www.hoard.org

Apache License 2.0

1.09k stars 127 forks source link

Allow macOS architectures to be configured #44

Closed ryandesign closed 5 years ago

ryandesign commented 5 years ago

GNUmakefile hardcodes the architectures for which to compile on macOS in the MACOS_COMPILE and MACOS_COMPILE_DEBUG variables. You should make this configurable via another makefile variable. Currently you're hardcoding the architectures i386 and x86_64, but Apple is phasing out 32-bit support and you can't compile for i386 anymore as of the macOS 10.14 SDK.

emeryberger commented 5 years ago

I have removed i386, which I think removes justification for this issue.