search

emesare / binja-msvc

Parses and symbolizes MSVC RTTI information in Binary Ninja.
MIT License
25 stars 6 forks source link

Windows CI build likely does not work #21

Closed CouleeApps closed 7 months ago

CouleeApps commented 9 months ago

I see you have based the github actions build for this off of https://github.com/CouleeApps/binja-ci-tests/blob/master/binja.patch and I just wanted to let you know that the Windows build this patch produces does not actually work... https://github.com/CouleeApps/binja-ci-tests/issues/1

I haven't had time to go figure out what the correct solution is, but just a heads up in advance that this is a known issue.

emesare commented 9 months ago

Thanks for opening the issue, my temporary solution has been manually building it and replacing the broken one.

Hopefully I can figure out a real solution soon because if I forget to replace the broken one I am sure someone is going to be really mad when their binary ninja doesn't open on windows 😃

CouleeApps commented 7 months ago

Latest updates to the base repo should support building on windows. I migrated it to https://github.com/Vector35/sample_plugin_cpp (which apparently breaks github actions, thanks github). Let me know if those changes get this repo to work, and if you run into any issues along the way :)

emesare commented 7 months ago

Latest updates to the base repo should support building on windows. I migrated it to https://github.com/Vector35/sample_plugin_cpp ~(which apparently breaks github actions, thanks github)~. Let me know if those changes get this repo to work, and if you run into any issues along the way :)

Fixed! Thanks again :)