emesterhazy / glossika-to-anki

Convert Glossika PDFs and audio files into Anki decks
MIT License
32 stars 8 forks source link

Correct PDF file name #14

Closed crstead closed 4 years ago

crstead commented 4 years ago

Hello - first off, excellent project and thank you for the effort and time spent to make this.

I've successfully split the audio, however the PDF splitting is having issues; I'm getting the following output:

Processing  GLOSSIKA-ENKR-EBK.pdf...unmatched
File name does not match
Skipping GLOSSIKA-ENKR-EBK.pdf
PDF extract complete!

What is the expected name format?

crstead commented 4 years ago

I had a look at the source code and figured out the file name format; actually the same solution as the previous issue. It should have been:

GLOSSIKA-ENKR-F1-EBK.pdf

I might contribute this to the readme, but at least the issue name will make it easy for others to find the solution.

emesterhazy commented 4 years ago

Hi @minceontoast - glad you figured it out. Please feel free to open a PR to update the readme. I think this is a great addition to make.

emesterhazy commented 4 years ago

On second thought, I'm also going to change the regex pattern here so that the string between the ENKR (the language id) and EBK is optional. I still think that the readme should discuss the expected file names, so feel free to open a PR :).