search

emezeske / lein-cljsbuild

Leiningen plugin to make ClojureScript development easy.
Other
1.1k stars 152 forks source link

:preamble fails silently for missing preamble files #476

Closed rbuchmann closed 7 years ago

rbuchmann commented 7 years ago

I am currently trying to use a preamble file, and noticed that it's possible to enter an incorrect filename there, or put the :preamble key outside of the compiler options, and cljsbuild will just silently ignore it.

I think there should be a warning for unknown keys in the configuration, as well as a warning if a preamble file could not be found.

rbuchmann commented 7 years ago

Correction: It should warn if the preamble setting is ignored because optimizations are :none 🤦‍♂️

mneise commented 7 years ago

As you already pointed out, ':preamble' is a ClojureScript compiler option, so you are welcome to create an issue there (https://dev.clojure.org/jira/browse/CLJS). Also, if you are interested in contributing to the compiler, this sounds like a good issue to start with 😉

rbuchmann commented 7 years ago

Hm, not the answer I was looking for, but quite reasonable. I remember watching a talk about this topic by someone with a name curiously similar to yours, maybe it's time to put into practice what I learned there :)