search

emfcamp / Mk2-Firmware

Firmware that runs on the TiLDA v2 Badge
18 stars 36 forks source link

Update PMIC and IMU interrupt handlers to be like FreeRTOS examples #119

Open jburgess777 opened 10 years ago

jburgess777 commented 10 years ago

This pull is more for comment & review rather than a firm pull request. I have no previous experience with FreeRTOS but the current code seems inconsistent with the examples of xEventGroupSetBitsFromISR() in event_groups.h and http://www.freertos.org/xEventGroupSetBitsFromISR.html

I have been wondering whether the PMIC is responsible for some lockups because the USB serial debug occasionally reports a flood of charge state changes. Perhaps there is noise on the MCP_STAT line or maybe the battery charger is oscillating between the charging and non-charging states as the dynamic CPU power usage effects the battery voltage.

marekventur commented 10 years ago

@dpslwk Shall we merge this? You're probably in the best position to judge this.