search

emfcamp / badge-2024-software

46 stars 29 forks source link

ctx.text_align not passed to app draw functions consistently #181

Open Robotmad opened 4 months ago

Robotmad commented 4 months ago

Describe the bug We had issues with our app not rendering as expected, apparently a bit random, in terms of text alignment. Work around was to explicitly set ctx.text_align and ctx.text_baseline every time.

Version: v1.8 & v1.9.0-beta1 (probably earlier too)

To Reproduce Not sure - just use the badge and then run app.

Expected behavior Expect ctx context to be passed into draw consistently each time - hence only need to set things that you want to be different to 'default'

Additional context Reporting now as I've seen it on CaffeineJitters too and have a suggestion of where the issue lies. I think the modules/app_components/menu.py draw function modifies ctx.text_align and ctx.text_baseine without saving and restoring.

walkerdanny commented 4 months ago

Second this, I was seeing some strange behaviour when testing some code yesterday. Your idea that something isn't saving and restoring the state feels right.