emfcamp / numbermanagement

EMF phone number management system
4 stars 4 forks source link

Add to an empty group - 500 #15

Closed an0key closed 1 month ago

an0key commented 2 months ago

If I try to navigate to https://phones.emfcamp.org/group/5853 and hit add, the group has no members, I get a 500 error.

I think this is due to ---- being selected in the group first, and clicking add, trys to add that number... works fine if I select one of the extensions from the dropdown

sammachin commented 2 months ago

ah yes UX bug, that dropdown is pretty knarly and we'd like to improve it

sammachin commented 2 months ago

easiest fix would be to disable the add button if a number isn't selected

sammachin commented 1 month ago

fixed in #18 image