search

emfcamp / numbermanagement

EMF phone number management system
4 stars 4 forks source link

Call to group fails via SIP #17

Closed an0key closed 4 months ago

an0key commented 5 months ago

Line 1 - 6666 (making the call) - SIP

Calling - Group 5853. That has a member 5060 (SIP).

Line 1 gets a busy signal when calling 5853 (Group). Can call 5060 directly no issue.

sammachin commented 4 months ago

this seems to be realted to provisioning of the group number into jambonz, likely due to the group number initially being created as an other ToS and the remove not being cleanly done. Need to validate all the deprovisioning flows and check caching

sammachin commented 4 months ago

I don't think this was due to the change number type now. I found a bug in the API groups code for join/leave that was triggering a remove of the group number from jambonz instead of just clearing the cache. The API is what gets calls when a user updates a group member via IVR. This was fixed by #e94b709b5671a2cde36a97c89b2f7259ed88e22a Also I made the IVR join/leave call flow more robust as it was failing on certain cases like joining via IVR if the group wasn't cached.

sammachin commented 4 months ago

Also fixed in https://github.com/emfcamp/numbermanagement/commit/bf1daeb4938d2e259e33b1c297a78b7f2339b0eb which was trigger a full remove not just a cache invalidation when number details were updated, this would be affecting App numbers too