search

emfjson / emfjson-jackson

JSON Binding for Eclipse Modeling Framework
https://emfjson.github.io
Other
80 stars 23 forks source link

Fix for not resolving proxies when building a reference #28

Closed BryanHunt closed 11 years ago

BryanHunt commented 11 years ago

When a reference is loaded from JSON which is a proxy, the reference is being resolved instead of being added as a proxy. This can cause serious performance issues when the JSON is being loaded from the network.

ghillairet commented 11 years ago

Great, thank you, I'll include it in version 0.5.2.

BryanHunt commented 11 years ago

Any idea when you can release 0.5.2? I'm currently blocked by this problem.

ghillairet commented 11 years ago

It should be in http://ghillairet.github.com/p2/emfjson/snapshots now.

BryanHunt commented 11 years ago

I picked up that build, and I'm seeing an exception with Jackson...

Caused by: java.lang.NoSuchMethodError: org.codehaus.jackson.JsonNode.getFields()Ljava/util/Iterator; at org.eclipselabs.emfjson.internal.JSONLoad.fillEAttribute(JSONLoad.java:175) at org.eclipselabs.emfjson.internal.JSONLoad.createEObject(JSONLoad.java:159) at org.eclipselabs.emfjson.internal.JSONLoad.fillResource(JSONLoad.java:142) at org.eclipselabs.emfjson.resource.JsResourceImpl.doLoad(JsResourceImpl.java:46)

ghillairet commented 11 years ago

Which version of Jackson are you using?

BryanHunt commented 11 years ago

1.6.0

On Jan 31, 2013, at 10:06 AM, Guillaume Hillairet notifications@github.com wrote:

Which version of Jackson are you using?

— Reply to this email directly or view it on GitHub.

ghillairet commented 11 years ago

Ok i am on 1.9.5. If you can update it, you can get it from this repo http://ghillairet.github.com/p2. Seems that getFields has been added to the class JsonNode since version 1.8.0, but was on ObjectNode since 1.0.

BryanHunt commented 11 years ago

I'm not getting the exception, but my fix is not working. I will debug and hopefully submit a pull request in a bit.

On Jan 31, 2013, at 10:07 AM, Bryan Hunt bhunt@mac.com wrote:

1.6.0

On Jan 31, 2013, at 10:06 AM, Guillaume Hillairet notifications@github.com wrote:

Which version of Jackson are you using?

— Reply to this email directly or view it on GitHub.