search

emfmesquita / beyondhelp

Chrome extension with helpers to https://www.dndbeyond.com/.
MIT License
21 stars 9 forks source link

[Feature Request]Add table of contents to each page #10

Closed dconman closed 6 years ago

dconman commented 6 years ago

As far as I can tell, on any given page of a rulebook, to get to a different chapter you must go back to the Table of Contents, then go to the corresponding chapter. It would be nice if somewhere on the page, either at the top or along the side collapsible there were links to the other chapters in the rulebook

emfmesquita commented 6 years ago

That is a good idea. I suffer from this myself XD. Added to the list of to do. Thanks.

dconman commented 6 years ago

I started working on this in my own fork It works, but it definitely could be better designed. I'll work on it some more soon. Any suggestions would be appreciated.

emfmesquita commented 6 years ago

That is amazing news! Thanks for the contribution! I will definitely take a look at it.

emfmesquita commented 6 years ago

I just tested you PR, and it looks amazing! Thanks again for the contribution. I just found two small things (I will add the comments on PR), and I think we can merge it.

emfmesquita commented 6 years ago

I changed my mind, just merged it. I will make the small changes XD. Basically I just added and empty array on TOCData for rules (it was trowing an ex for rule books). And on TOCService I just added a return if the book is not found on TOCData (It was removing the menu on books with no entry on data).

So it will be on the next release. Probably I will do this weekend after I finish the damn extra map refs XD.

Btw feel free to create more PRs if you want to change something.

Thanks again!