search

emfoundation / asset-manager

Digital Asset Management System
GNU General Public License v3.0
7 stars 3 forks source link

js filename validation for Asset files #196

Open georgemillard opened 6 years ago

georgemillard commented 6 years ago

As first mentioned in #176 django storages strips () out of filenames before Django's filename validation. This could cause problems, so it is suggested that some js filename validation is implemented prior to Django's.

Merton commented 6 years ago

Taken from Pull request 190: " As discussed in issue #176 , the () and ' chars are being removed after saving. This might be confusing to the user (and allows duplicate filenames).

I also came across that if your file contains a backslash character, \, it removes any text that precedes it. Ex: if the file is called test.txt, it will save as .txt if it is called test\backslash.txt it will save as backslash.txt

There is no prompt to the user of this happening, and whilst I don't expect many files to contain a backslash this is unexpected behaviour when saving files. "