search

emgarten / Sleet

A static nuget feed generator for Azure Storage, AWS S3, and more.
MIT License
362 stars 43 forks source link

FEATURE: added support for accessKey and secretKey stored as env vari… #94

Closed seroche closed 5 years ago

seroche commented 5 years ago

FEATURE: added support for accessKey and secretKey stored as env variables FEATURE: added support of codes ran within an ECS container FEATURE: made CreateFileSystem async

seroche commented 5 years ago

I tested the following use cases:

It looks fine to me. I will test the ECS behavior once you publish a new version. It will automatically be downloaded within my CI flow.

emgarten commented 5 years ago

@seroche thank you for the PR, this looks like a great approach for detecting the AWS environment while still keeping the same behavior for existing scenarios.

The work to make CreateFileSystemAsync looks great as well, thanks for fixing up the tests. I appreciate the effort here. 💯

seroche commented 5 years ago

My pleasure! Do you have CI/CD flow auto publishing a new version?

emgarten commented 5 years ago

CI/CD will auto push the new packages to https://nuget.blob.core.windows.net/packages/index.json

Releasing to nuget.org is automated, but a manual decision so that not all builds get pushed there. The build seems to be running slow at the moment, but I'll release the new build to nuget.org tomorrow if all end to end tests pass.

emgarten commented 5 years ago

@seroche this change is available in https://www.nuget.org/packages/Sleet/3.0.13

emgarten commented 5 years ago

Thanks again for the work on this 🍰