emgen-science / UCBioinformatics

Code I write for the UC BIOL6002C which I teach
0 stars 0 forks source link

Confirm that use of BLAST's `-max_target_seqs` is intentional #1

Open armish opened 6 years ago

armish commented 6 years ago

Hi there,

This is a semi-automated message from a fellow bioinformatician. Through a GitHub search, I found that the following source files make use of BLAST's -max_target_seqs parameter:

Based on the recently published report, Misunderstood parameter of NCBI BLAST impacts the correctness of bioinformatics workflows, there is a strong chance that this parameter is misused in your repository.

If the use of this parameter was intentional, please feel free to ignore and close this issue but I would highly recommend to add a comment to your source code to notify others about this use case. If this is a duplicate issue, please accept my apologies for the redundancy as this simple automation is not smart enough to identify such issues.

Thank you! -- Arman (armish/blast-patrol)

emgen-science commented 5 years ago

@armish Thanks dude! I definitely saw that, it was interesting! I will be modifying the code for future use. This is currently just a version for my students in Bioinformatics class to reference as they write their own, but I'm going to add that report into the class as reading as I think it is interesting for them to see and understand how important it is that we all understand what our code is doing!