search

emgram769 / lighthouse

A simple scriptable popup dialog to run on X.
MIT License
634 stars 31 forks source link

Pass unused arguments to cmd handler #43

Open 0ion9 opened 9 years ago

0ion9 commented 9 years ago

When using lighthouse for things more specific than a generic application launcher, the ability to pass unused arguments on to cmd would be helpful.

The clearest example of how this would look is lighthouse -- some extra arguments, though of course lighthouse -c configfile some extra arguments would also need to be handled. Both of those cases should lead to cmd being called as cmd some extra arguments.

For example usage, TMSU tagging / untagging : the list of files to be tagged/untagged should be available, so that, when tagging, tags that are already applied are not included in the option list, and so that, when untagging, only tags that are currently applied are included in the options list.

0ion9 commented 9 years ago

I thought about this and considered that you may have intended this kind of thing to be done via environment variables, eg TAGS="foo bar" lighthouse That's fine as long as you don't need varying numbers of args, I guess. Anyway I went ahead and implemented this, and submitted a pull request.

In the process, I spotted the fact that wordfree() is not used in spawn_piped_process() after spawning the child process. Is this correct, or a memory leak?