search

emhart / 10-simple-rules-data-storage

A repository for the 10 simple rules data sharing paper to be submitted to PLoS Comp Biology
Creative Commons Zero v1.0 Universal
25 stars 13 forks source link

Naupaka's overall comments, proofreading, revisions #73

Closed naupaka closed 9 years ago

naupaka commented 9 years ago

It looks like I changed a ton, but I really didn't change all that much (although there are revisions and tweaks throughout). I just consistently wrapped the lines, which should make diffing much easier in the future. I also regenerated the pdf.

jhollist commented 8 years ago

@naupaka, sorry to dredge this up, but quick question/observation about the line wrapping (and apologies If I am pointing out something obvious)

I have always hated the default diff with md as I don't wrap my lines when I write, so a paragraph is just one big line to git. Is this what you were trying to enforce with the line wrapping so that we could see line by line changes? If so, that's great but then makes editing a pain because you have to fix line wraps whenever you make a change to the document.

Well this (the diff rendering, not your PR!) was bothering me today and I found the "Rich Diffs", which appear to have been around for a couple of years. When viewing the diff, the document icon at the top right switches to rich diff and then the changes you want to see appear!

Again, apologies if I am pointing out the obvious...

naupaka commented 8 years ago

@jhollist yeah - I know it's a pain... I was trying to make it easier with the default diffs. I didn't know about the rich diffs! That's pretty slick. I guess I had imagined it wouldn't be too much hassle since most people (?) would be writing in vim, so could use vapgqto re-wrap, or emacs, with M-q, or CMD-OPT-q in Sublime. But, perhaps all are still extra effort, and the rich diff it indeed exactly what I was trying to get closer to anyway.