If no cels are listed for a set, the set number shouldn't be clickable

emhoracek / smooch

Kisekae Set System implementation for the web

GNU General Public License v3.0

47 stars 25 forks source link

If no cels are listed for a set, the set number shouldn't be clickable #57

Open emhoracek opened 6 years ago

emhoracek commented 6 years ago

Ophelia St Morphine by Satori is a good example.

Only the first set has any clothes:

The rest are empty:

This is intended by the artist to mean that those sets shouldn't be selectable, only the first is intended for view.

If you look through the setdata.js for this doll, you'll see that all the cels say "sets": [0].

I have some ideas for how to approach this, if you would like to try taking this issue but you're not sure where to start.

emhoracek commented 6 years ago

@hernandesdoug Would you like to try this one? I'm happy to help you get set up if you aren't sure how to get started.

ghost commented 6 years ago

Hi @emhoracek Yes, I would.

emhoracek commented 6 years ago

@hernandesdoug I don't seem to have the process documented anywhere in this repository, but you can follow these slides from a recent workshop to get started on this issue. Please comment if you run into any trouble or confusion.

ghost commented 6 years ago

Thank you @emhoracek I will fork the repo and work on it. I will let you know if I have any problem.

emhoracek commented 2 years ago

The person who originally claimed this has deleted their account, so this issue is up for grabs again.