emhoracek / smooch

Kisekae Set System implementation for the web
GNU General Public License v3.0
46 stars 25 forks source link

Keep cnf cel ordering #93

Closed emhoracek closed 2 years ago

emhoracek commented 2 years ago

Fixes #8.

This moves the grouping of cels into objs from the backend CNF parser to the frontend. Right now, we group object twice - first on the backend and then again when we process the JSON into JavaScript objects. That introduced some subtle bugs like #8 (still don't know what was causing that). But if we just send the listing of cels with object "marks" ungrouped, and group them on the frontend, we can use an imperative method that's a lot closer to the way that existing KiSS viewers do it.

This code is a little simpler so even if it's less "functional" I'm still happy. :)