emichael / dslabs

Distributed Systems Labs and Framework
https://ellismichael.com/dslabs/
1.26k stars 341 forks source link

Use most recent SearchSettings in new debugger #30

Closed gnanabite closed 2 years ago

gnanabite commented 2 years ago

For searches that use one-off SearchSettings, the searchSettings field of the BaseJUnitTest won't have the required information. For example, see initView of lab 2: since we're using the settings in the BaseJUnitTest, the debugger will open but there won't be any settings.

The fix is to save the settings used in the last search, similar to https://github.com/emichael/dslabs/pull/20#discussion_r803341651; this time we need to save the settings from both BFS and DFS.

Tested:

emichael commented 2 years ago

LGTM! Once I get around to merging feature/save-traces, we should probably clone the settings to defend against the settings changing after the search but before assertGoalFound gets invoked. It's not necessary, though.