search

emichael / dslabs

Distributed Systems Labs and Framework
https://ellismichael.com/dslabs/
1.26k stars 341 forks source link

Migrate from numeric primitive times to Instant/Duration #49

Open emichael opened 1 year ago

emichael commented 1 year ago

We should be using Instant and Duration from the java.time package instead of millisecond times stored as longs or ints.

ChrisPerezLebron commented 1 year ago

Hi, I am new to open source and would love to help out. Could you provide me with more information regarding where in the codebase these changes need to be made?

AsfarHorani commented 1 year ago

@emichael any further information? i am done with cloning the repo which classes do I have to work on? image

AsfarHorani commented 1 year ago

@emichael Please assign it to me

AsfarHorani commented 1 year ago

/assign

emichael commented 1 year ago

Hi, Asfar and Chris. Thanks so much for the offer to help! This is really something I want someone who's already done the labs and is familiar with the codebase to tackle, though.

AsfarHorani commented 1 year ago

Ahh that's really sad. I saw the good first issue tag and i wanted to contribute. If u get some time u can explain me code base for a while.

AsfarHorani commented 1 year ago

@emichael if there's any other issue i can work on please let me know thanks