search

emichael / dslabs

Distributed Systems Labs and Framework
https://ellismichael.com/dslabs/
1.23k stars 339 forks source link

Compute client waiting time without including testing framework time #54

Closed emichael closed 10 months ago

emichael commented 1 year ago

This commit adds a private field to RunState to track when the system under test was most recently stopped. Then, when checking ClientWorkers' maximum wait times, we use that time as the basis for computing the maximum wait time.

This is a modification of @wilcoxjay's original fix, but I think it's a little bit cleaner to not force every test to call a specific method before calling assertMaxWaitTimeLessThan.

emichael commented 1 year ago

Fixes #48.

emichael commented 1 year ago

This is totally untested. Will need to add some sort of testing later or at least verify by hand that this still works.

@wilcoxjay for some reason I can't add you as a reviewer, but what do you think?

emichael commented 1 year ago

Replaces #50.

wilcoxjay commented 1 year ago

Looks great! I like this approach a lot more.

wilcoxjay commented 10 months ago

I ran into this problem again today. Can we merge this?