search

emichael / dslabs

Distributed Systems Labs and Framework
https://ellismichael.com/dslabs/
1.23k stars 339 forks source link

Add ability to show/hide event types in Events list in viz #60

Closed emichael closed 10 months ago

emichael commented 10 months ago

Adds a toggle pane on the side that shows/hides the messages in each node's inbox area.

This commit might address #59, but I'm not sure.

emichael commented 10 months ago

@wilcoxjay is this what you had in mind for #59?

image

I'm just now realizing you might have meant the list on the right side of the window. What sort of UI were you thinking?

wilcoxjay commented 10 months ago

Ah, yeah, I actually meant the right-hand pane. The use case is a failing random DFS search trace that is like 50 messages long and most of them are Pings I don't care about :)

emichael commented 10 months ago

Ahhhh, gotcha. Any ideas for the UI for setting the filters? Should this be in the left side pane like I have these settings or maybe a pop up menu with something similar (and where would you open the pop up menu)?

wilcoxjay commented 10 months ago

I think the simplest thing is just more checkboxes on the far left.

emichael commented 10 months ago

Okay, I think this implementation makes sense now. @wilcoxjay want to try it out and kick the tires on it?

wilcoxjay commented 10 months ago

Looks good to me! If you try to filter out an event that matches the current state you're looking at, then it is not filtered but still shown. But I think this is probably good behavior anyway.

emichael commented 10 months ago

Yes, that was intentional.

Alright, cool. I'll merge this. Let me know how it works and if people find it useful