search

emichael / dslabs

Distributed Systems Labs and Framework
https://ellismichael.com/dslabs/
1.23k stars 339 forks source link

Comma separated part numbers for run-tests.py #66

Closed armanbm177 closed 8 months ago

armanbm177 commented 9 months ago

Enabled multiple part nums to be run in sequence for run-tests.py. Inspired by the lab 4 part 3 exploit, that doesn't require a working part 2 to get a majority of part 3 points.

Example terminal commands: ./run-tests.py -l 4 -p 2,3

wilcoxjay commented 9 months ago

you need to only allow non-fully-qualified test numbers when there is exactly one part specified.

That is -l 1 -p 2 -n 4 should work, but -l 1 -p 2,3 -n 4 should not.

This makes sense to me. Is it ok to only put this check in the python script, or do we enforce these things in both python and java?

emichael commented 9 months ago

Either/both is fine. There could be more input validation and better error messages for the student facing scripts in general :-)