emigre / openseadragon-annotations

Draw annotations over deep zoom images
BSD 3-Clause "New" or "Revised" License
97 stars 40 forks source link

When calling new OpenSeadragon.Annotations({ viewer }); there is an error #30

Open AdamOrHd123 opened 3 years ago

AdamOrHd123 commented 3 years ago

Hi, I'm trying to use the annotations.js. I am deploying it from my main html file like this:

I need to create annotation per viewer. I'm doing it like this: myAeeay.push(new OpenSeadragon.Annotations({viewre_})) I get an error saying that Annotations is undefined. What am I missing? Really thanks for any help and guidance

iangilman commented 3 years ago

Are you including the OpenSeadragon library first? Are you getting any errors loading the scripts?

AdamOrHd123 commented 3 years ago

Hi Ian Thanks for reaching out Actually I am able to create annotations by calling the api : initiaizeAnnotations() However, there is an issue when trying to have this plug-in work on multiple instances of OSD Viewer When I try to call this method on the second instance, I get: Uncaught Error: The OpenSeadragon Annotations plugin is already running This makes me understand that the plug-in can't work in parallel. So I am using shutdownAnnotations api in order to shift between instances But now I get a new problem, where the flow is not robust and I end up with the above error. This makes me assume that shutdown didn't really shut/remove itself. Did you encounter it? This is the code I use to shift around between instances: image

iangilman commented 3 years ago

I actually don't know that much about this plugin. Odd that it seems to only work on one viewer at a time! What does the code look like for that? Do you literally create two viewers and then call new OpenSeadragon.Annotations({ viewer }) with each one?

Have you poked around in the code of the plugin? There might be some clues there...

AdamOrHd123 commented 3 years ago

Hi Ian, Thanks for trying to help me, really When I use: OpenSeadragon.Annotations({ viewer }), I get an error: Uncaught SyntaxError: missing : after property id Do you have a lead here? I'm missing something basic. Alternatively, I could work with Annotorious, however I don't see the controls being avaialble. I opened an issue on the github of Annotorious.

AdamOrHd123 commented 3 years ago

This is the ticket I opened on Annotorious: https://github.com/recogito/annotorious-openseadragon/issues/49

iangilman commented 3 years ago

When you say you use OpenSeadragon.Annotations({ viewer }), do you mean new OpenSeadragon.Annotations({ viewer })? The latter is what the docs say, and it makes a difference.

It does look like Annotorious is more actively supported than this plugin, if that makes any difference.