emikulic / darkhttpd

When you need a web server in a hurry.
https://unix4lyfe.org/darkhttpd/
ISC License
1.03k stars 83 forks source link

Linting? Code formatting? #22

Closed hhartzer closed 2 years ago

hhartzer commented 2 years ago

Do you use a particular linter of automatic code formatter for darkhttpd?

I see there's lots of integration tests. Very nice.

emikulic commented 2 years ago

Autoformat sadly no. These days I would use clang-format but this code is very old and I don't think consistent within the one file.

Probably better to live with it, than cause version control noise by introducing autoformatting now.

As for lint, I think enabling a lot of compiler warnings is the best ROI. I've tried cppcheck and clang static analysis and didn't get much out. OTOH fuzzing was helpful.

hhartzer commented 2 years ago

That makes sense. Thank you!