search

emikulic / darkhttpd

When you need a web server in a hurry.
https://unix4lyfe.org/darkhttpd/
ISC License
1.05k stars 87 forks source link

Don't say tests are successful when they are not #53

Closed hhartzer closed 8 months ago

hhartzer commented 8 months ago

Fixes: #52

hhartzer commented 8 months ago

It looks like there have been a few changes lately that have broken tests in interesting ways.

This includes:

All good changes, but it would be good if we can get the tests to catch up to the code. Would appreciate contributions to this PR if anyone is up for it.

emikulic commented 8 months ago

I just fixed TestDirList, I'll try to do a few more. https://github.com/emikulic/darkhttpd/commit/3a72fc4b73895ebe37dc33ac04217f70e77c8e53

emikulic commented 8 months ago

Try now.

hhartzer commented 8 months ago

Awesome, thank you!

It works for me as long as I'm not root. If I'm root, the forbidden tests don't respond properly.

I think this should be good now.

emikulic commented 8 months ago

I'm ok with run-tests requiring non-root. :)

hhartzer commented 8 months ago

Me too. Thank you!