emilbayes / secure-password

Making Password storage safer for all
ISC License
569 stars 22 forks source link

Sodium variable are undefined for the javascript version #9

Closed timmak closed 7 years ago

timmak commented 7 years ago

Error: opts.memlimit must be at least MEMLIMIT_MIN (undefined)

Seems the js version of sodium does not include the variables. Also sodium.crypto_pwhash_str_async seems to be missing in the js version

emilbayes commented 7 years ago

Hi @timmak,

Argon2i is not part of sodium-javascript which is the browser version of sodium-native. I don't know if we will implement it as will take considerable time to do so and test thoroughly, so I should probably change the dependency from sodium-universal to sodium-native. What's your usecase?

timmak commented 7 years ago

Completely understand, was trying to use it with [https://github.com/zeit/pkg]() which was resolving to the javascript one. Still trying to get it to work with the sodium-native but this is different issue to the one above.

emilbayes commented 7 years ago

You can find me on IRC in #choo, #browserify and #stackvm on freenode if you need help :)

emilbayes commented 7 years ago

Please reopen if you have more to share about using secure-password with pkg