search

emilgoldsmith / stylelint-custom-processor-loader

A Webpack loader for stylelint used with custom processors
MIT License
24 stars 3 forks source link

Align peer dependencies with the ones defined in dev dependencies #16

Closed oliverlaz closed 7 years ago

oliverlaz commented 7 years ago

It seems that peer dependencies were not updated together with the respective dev dependencies.

This change prevents Incorrect peer dependency "stylelint@7.13.0" and Incorrect peer dependency "webpack@3.2.0" warnings from showing up during yarn or npm install.

emilgoldsmith commented 7 years ago

Thanks for the PR @oliverlaz :). Yep forgot that, and I in general want to also include some CI tests where I use some different versions so I can confidently way increase the range of the peerDependency version.

Also looks like something weird is going with the CI config, and at this very moment I can't even rebuild as apparently CircleCI is having some issues, so I'll just override merge this in.

Thanks again :)

oliverlaz commented 7 years ago

Thanks for the merge! 👍

I use this plugin in one of my projects, in a combination with stylelint 8.1.0. So far everything runs smooth.